Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MPDG -> MPGD #1562

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: MPDG -> MPGD #1562

merged 1 commit into from
Aug 9, 2024

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Aug 9, 2024

Briefly, what does this PR introduce?

This PR renames an input hit collection. Not as important since this isn't in craterlake, but code gets copied...

What kind of change does this PR introduce?

  • Bug fix (issue: incorrect hit collection name)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators @mposik1983

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested review from a team and ruse-traveler and removed request for a team August 9, 2024 03:45
@wdconinc wdconinc enabled auto-merge August 9, 2024 03:45
Copy link

sonarqubecloud bot commented Aug 9, 2024

Copy link
Contributor

@mposik1983 mposik1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hit collection is left over from the arches configuration. These can be removed as they are no longer used.

@wdconinc wdconinc added this pull request to the merge queue Aug 9, 2024
Copy link
Contributor

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Merged via the queue into main with commit 5db8eea Aug 9, 2024
87 checks passed
@wdconinc wdconinc deleted the wdconinc-patch-3 branch August 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants