Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEventProcessorPODIO: make podio:output_include_collection deprecation warning more compelling #1606

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 2, 2024

Briefly, what does this PR introduce?

This improves the wording to actually help general users get rid of the delay, that they may not know about.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@veprbl veprbl requested a review from wdconinc September 2, 2024 17:25
@veprbl veprbl changed the title JEventProcessorPODIO: make podiot:output_include_collection deprecation warning more compelling JEventProcessorPODIO: make podio:output_include_collection deprecation warning more compelling Sep 2, 2024
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should parametrize the wait time, randomized based on the number of days since mid-August, exponential increase, asymptote at Thanksgiving, and use that in the message.

Or what you have is fine too.

@veprbl veprbl enabled auto-merge September 10, 2024 20:27
Copy link

@veprbl veprbl added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit df5ece6 Sep 11, 2024
86 of 87 checks passed
@veprbl veprbl deleted the pr/compelling_oic_deprecation branch September 11, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants