Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MPGD.cc thresholds #1619

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Update MPGD.cc thresholds #1619

merged 1 commit into from
Sep 19, 2024

Conversation

mposik1983
Copy link
Contributor

Briefly, what does this PR introduce?

Changes MPGD threshold values to 100 eV based on updated estimates

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • [x ] Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • [x ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No breaking changes. MPGD layers will now have more efficient hit reconstruction

Does this PR change default behavior?

MPGD detectors will see increase in hit reconstruction efficiency

Set threshold values to 100 eV
@mposik1983 mposik1983 added topic: tracking Relates to tracking reconstruction improvement Not a bug, not a feature, but an improvement of what is there labels Sep 19, 2024
@mposik1983 mposik1983 requested a review from wdconinc September 19, 2024 14:08
Copy link

@wdconinc wdconinc added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 92b2f5a Sep 19, 2024
86 of 87 checks passed
@wdconinc wdconinc deleted the mpgd_threshold_change branch September 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug, not a feature, but an improvement of what is there topic: barrel topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants