Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JANA2-related deprecation warnings and TODOs #1622

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Fix JANA2-related deprecation warnings and TODOs #1622

merged 3 commits into from
Sep 21, 2024

Conversation

nathanwbrei
Copy link
Contributor

@nathanwbrei nathanwbrei commented Sep 21, 2024 •
edited
Loading

Briefly, what does this PR introduce?

This cleans up the EICrecon compilation output by fixing some deprecation warnings coming from JANA2. It also removes some JANA2-related TODO comments. It updates a test case to no longer use a template method that hasn't been deprecated, but is about to be.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: Fixes deprecation warnings

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: far-forward Far forward reconstruction topic: far-backward Reconstruction related to far backward detectors topic: infrastructure topic: barrel topic: forward topic: backward labels Sep 21, 2024
@nathanwbrei nathanwbrei force-pushed the nbrei_jana2_deprecations branch 2 times, most recently from 6022072 to 880991d Compare September 21, 2024 03:49
@nathanwbrei
Migrate away from JFactorySet::GetFactory<T>()
8efe3a1 
This will be going away in a future release. JFactorySet won't have any dependency on JFactoryT (and neither will Podio factories) and won't have any template methods.
@nathanwbrei
Migrate away from old JParameterManager::PrintParameters()
0367bba 
This is already deprecated and emits a bunch of warnings during compilation.
@nathanwbrei
Remove old TODO: NWB comments
93f054b 
These reflect past issues with JANA2, not EICrecon. They have been addressed there.
@nathanwbrei nathanwbrei force-pushed the nbrei_jana2_deprecations branch from 880991d to 93f054b Compare September 21, 2024 04:29
@github-actions GitHub Actions
Copy link

Capybara summary for PR 1622

@nathanwbrei nathanwbrei requested a review from veprbl September 21, 2024 05:05
veprbl
veprbl approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit b2a846e Sep 21, 2024
85 of 86 checks passed
@veprbl veprbl deleted the nbrei_jana2_deprecations branch September 21, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
topic: backward topic: barrel topic: calorimetry relates to calorimetry topic: far-backward Reconstruction related to far backward detectors topic: far-forward Far forward reconstruction topic: forward topic: infrastructure topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanwbrei @veprbl