CKFTracking: gracefully handle failures when extrapolating to perigee surface

[veprbl]

Briefly, what does this PR introduce?

Starting with Acts 34.x the CKF fitting had been divorced from propagation to the target surface acts-project/acts@d9f775f, so we now have to do it ourselves:

EICrecon/src/algorithms/tracking/CKFTracking.cc

Lines 278 to 296 in 5e39885

	#if Acts_VERSION_MAJOR >=34
	auto smoothingResult = Acts::smoothTrack(m_geoctx, track, logger());
	if (!smoothingResult.ok()) {
	ACTS_ERROR("Smoothing for seed "
	<< iseed << " and track " << track.index()
	<< " failed with error " << smoothingResult.error());
	continue;
	}
	auto extrapolationResult = Acts::extrapolateTrackToReferenceSurface(
	track, *pSurface, extrapolator, extrapolationOptions,
	Acts::TrackExtrapolationStrategy::firstOrLast, logger());
	if (!extrapolationResult.ok()) {
	ACTS_ERROR("Extrapolation for seed "
	<< iseed << " and track " << track.index()
	<< " failed with error " << extrapolationResult.error());
	continue;
	}
	#endif

However the catch is that B0 CKF tracks may be affected by failures to extrapolate explicitly. The failure currently leads to a null pointer dereference. This PR changes that to a mere warning, the track is omitted from the output in the process. We would be able to upgrade to Acts 34 with this change.

What kind of change does this PR introduce?

• Bug fix (issue #__)
• New feature (issue #__)
• Documentation update
• Other: __

Please check if this PR fulfills the following:

• Tests for the changes have been added
• Documentation has been added / updated
• Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

[github-actions]

Capybara summary for PR 1663

• rec_dis_10x100_minQ2=0_craterlake
• rec_dis_10x100_minQ2=1000_craterlake_tracking_only
• rec_dis_18x275_minQ2=0_craterlake_18x275
• rec_dis_18x275_minQ2=1000_craterlake_18x275
• rec_dis_5x41_minQ2=0_craterlake_5x41
• rec_e_1GeV_20GeV_craterlake
• rec_pi_1GeV_20GeV_craterlake
  ^{_{Last updated 2024-11-02T19:19-04:00 c50dd4a}}

[wdconinc]

Looks good.