Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 acts tracking with b0 trackers #405

Merged
merged 45 commits into from
Jul 1, 2023
Merged

404 acts tracking with b0 trackers #405

merged 45 commits into from
Jul 1, 2023

Conversation

rahmans1
Copy link
Contributor

Briefly, what does this PR introduce?

Add acts tracking for B0 trackers

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

N/A

Does this PR change default behavior?

Use B0 tracker hits in reconstruction

@rahmans1 rahmans1 self-assigned this Dec 25, 2022
@rahmans1 rahmans1 linked an issue Dec 25, 2022 that may be closed by this pull request
ACTS tracking with B0 trackers #404
Closed
@wdconinc wdconinc mentioned this pull request Jan 3, 2023
Merged
6 tasks
rahmans1 added 12 commits January 15, 2023 12:34
@rahmans1 rahmans1 changed the title 404 acts tracking with b0 trackers Draft: 404 acts tracking with b0 trackers Mar 9, 2023
@rahmans1 rahmans1 added the topic: far-forward Far forward reconstruction label Mar 9, 2023
@rahmans1 rahmans1 changed the title Draft: 404 acts tracking with b0 trackers 404 acts tracking with b0 trackers Jun 27, 2023
@rahmans1
Revert printing debugging output info for inverse context matrix
cc24aac 
No need to print inverse context matrix and manually calculated local hit info at this level. Manually calculated local hit is wrong anyway because it doesn't capture the full complexity of the ACTS affine transform that takes care of global to local transformation.
@rahmans1 rahmans1 requested a review from wdconinc June 28, 2023 03:03
wdconinc
wdconinc reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

src/detectors/B0TRK/B0TRK.cc Outdated Show resolved Hide resolved
src/detectors/B0TRK/B0TRK.cc Outdated Show resolved Hide resolved
src/algorithms/tracking/TrackerSourceLinker.cc Outdated Show resolved Hide resolved
@rahmans1 rahmans1 requested a review from wdconinc July 1, 2023 03:06
wdconinc
wdconinc approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@wdconinc wdconinc mentioned this pull request Jul 1, 2023
Closed
@rahmans1 rahmans1 enabled auto-merge (squash) July 1, 2023 17:52
@rahmans1 rahmans1 merged commit 71b7c99 into main Jul 1, 2023
@rahmans1 rahmans1 deleted the 404-acts-tracking-with-b0-trackers branch July 1, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc wdconinc approved these changes

Assignees

@rahmans1 rahmans1

Labels
topic: far-forward Far forward reconstruction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACTS tracking with B0 trackers
2 participants
@rahmans1 @wdconinc