Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clang-tidy-diff options differ from clang-tidy #438

Merged
merged 20 commits into from
Jan 30, 2023
Merged

fix: clang-tidy-diff options differ from clang-tidy #438

Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c7dbf18
fix: propagate parameters from reco_flags to cpp plugins
wdconinc Dec 28, 2022
48b547f
fix typo
wdconinc Dec 28, 2022
028c0bd
publish both arches and brycecanyon flags
wdconinc Dec 28, 2022
f99873f
HCAL:HcalEndcapPIslandProtoClusters:localDistXY
wdconinc Dec 28, 2022
f4176e5
HCAL:HcalEndcapNIslandProtoClusters:localDistXY
wdconinc Dec 28, 2022
d5fbf4e
HCAL:HcalBarrelIslandProtoClusters:localDistXY
wdconinc Dec 28, 2022
9b570e1
EEMC:EcalEndcapPTruthClusters:logWeightBase
wdconinc Dec 28, 2022
2dbd6aa
EEMC:EcalEndcapNRawHits:energyResolutions
wdconinc Dec 28, 2022
cb19728
BEMC:EcalBarrelScFiRawHits:dynamicRangeADC
wdconinc Dec 28, 2022
1afbad9
Add particle in dump_flags; use pi for pages
wdconinc Dec 29, 2022
bdc9e30
Remove unused files
wdconinc Dec 29, 2022
4912604
fix: remaining EEMC and HCAL corrections
wdconinc Jan 12, 2023
6ec6553
Typo
wdconinc Jan 12, 2023
473f8db
Chi2CutOff 15
wdconinc Jan 12, 2023
77443e9
EEMC:EcalEndcapPIslandProtoClusters:localDistXY
wdconinc Jan 13, 2023
ccbd8de
EEMC:EcalEndcapPInsertIslandProtoClusters:localDistXY
wdconinc Jan 13, 2023
f6ee368
fix: clang-tidy-diff options differ from clang-tidy
wdconinc Jan 14, 2023
02289dd
fix: use run-clang-tidy
wdconinc Jan 14, 2023
cc8dac3
Merge branch 'main' into fix-clang-tidy
wdconinc Jan 28, 2023
e0b0e69
Merge branch 'main' into fix-clang-tidy
wdconinc Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linux-eic-shell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
with:
platform-release: "jug_xl:nightly"
run: |
git diff ${{github.event.pull_request.base.sha}} | clang-tidy-diff -p build -export-fixes clang_tidy_fixes.yml -extra-arg='-std=c++17'
git diff ${{github.event.pull_request.base.sha}} | clang-tidy-diff -p 1 -path build -quiet -export-fixes clang_tidy_fixes.yml -extra-arg='-std=c++17' -clang-tidy-binary run-clang-tidy
- uses: eic/run-cvmfs-osg-eic-shell@main
if: ${{ github.event_name == 'push'}}
with:
Expand Down