Replace CalorimeterScFiDigi with CalorimeterHitDigi, implement merging at digi step #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chao1009
changed the title
|
It's still a draft, testing on my local copy now. |
|
Added @veprbl for review, knowing this is still a draft. |
Chao1009
changed the title
|
Now it only throws a warning and switches to single-hit digi mode, if a provided field does not exist. |
Chao1009
force-pushed
the
implement_digi_merge
branch
from
4bfe8f4 to
7c6179e
Compare
|
It 's ready |
|
File size certainly looks a lot better. |
Chao1009
force-pushed
the
implement_digi_merge
branch
from
5add1ea to
7c6179e
Compare
|
Please merge, if this is ready. |
wdconinc
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
It replaces the algorithm CalorimeterScFiDigi with CaloriemterHitDigi because the former breaks the production run of arches configuration.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
It should not affect the default use of CalorimeterHitDigi. However, it implements the merging at the digitization step, which can be enabled by using the required parameters.
Does this PR change default behavior?
It should not affect the default use of CalorimeterHitDigi.