fix: disable momentum in reco/truth particle matching #496
Conversation
This effectively disables the momentum in reconstructed vs truth particle matching, and increases the phi tolerance from 0.03 to 0.1 rad.
wdconinc
force-pushed
the
450-reconstructedchargedparticlesassociations-with-too-often-missing-associations
branch
from
bef0e64 to
cd3b0b5
Compare
|
@bspage912 is this something you can easily test? |
|
Hey Wouter, in principle this should be easy to test, just run one MC file through EICrecon with the new algo. In practice, it may take a bit as I will have to go back and remind myself how to run things. This change is so simple, I can't imagine any unexpected behaviour ... |
|
@bspage912 Can you approve this here, just based on the changes and not testing if you agree with the changes? I can then tag a release and submit some jobs for more detailed testing. |
…s-with-too-often-missing-associations
There was a problem hiding this comment.
While I have not explicitly tested this branch, I did emulate the matching algorithm in my offline tests without the relative momentum condition and with the phi tolerance changed to 0.1 and saw improved behaviour. This leads me to believe the changes in this branch should be fine to merge in.
wdconinc
deleted the
450-reconstructedchargedparticlesassociations-with-too-often-missing-associations
branch
Briefly, what does this PR introduce?
This effectively disables the momentum in reconstructed vs truth particle matching, and increases the phi tolerance from 0.03 to 0.1 rad. Closes #450.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes, less strict matching.