Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CKFTracking: disable RTTI type checks until EICrecon conforms to ODR #551

Merged
merged 3 commits into from
Mar 27, 2023
Merged

CKFTracking: disable RTTI type checks until EICrecon conforms to ODR #551

merged 3 commits into from
Mar 27, 2023

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 16, 2023

Briefly, what does this PR introduce?

Workaround for #340

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@veprbl veprbl requested a review from DraTeots March 18, 2023 23:42
@DraTeots DraTeots enabled auto-merge (squash) March 19, 2023 04:51
@DraTeots DraTeots closed this Mar 19, 2023
auto-merge was automatically disabled March 19, 2023 04:52

Pull request was closed

@DraTeots DraTeots deleted the pr/CKFTracking_no_RTTI branch March 19, 2023 04:52
@veprbl veprbl restored the pr/CKFTracking_no_RTTI branch March 19, 2023 22:02
@veprbl veprbl reopened this Mar 19, 2023
@veprbl veprbl requested a review from DraTeots March 19, 2023 22:02
@DraTeots DraTeots enabled auto-merge (squash) March 23, 2023 16:08
@DraTeots DraTeots merged commit f375494 into main Mar 27, 2023
@DraTeots DraTeots deleted the pr/CKFTracking_no_RTTI branch March 27, 2023 19:36
veprbl added a commit that referenced this pull request Sep 24, 2023
@veprbl
Revert "CKFTracking: disable RTTI type checks until EICrecon conforms…
80596a5 
… to ODR (#551)"

This reverts commit f375494.
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2023
@veprbl
Revert "CKFTracking: disable RTTI type checks until EICrecon conforms…
5c987a1 
… to ODR (#551)" (#1015)

I don't have a proof of ODR compliance at this time, but, at least, this
issue was recently resolved (likely by #940).

This reverts commit f375494.

Closes: #340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DraTeots DraTeots DraTeots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ePIC Software and Computing
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veprbl @DraTeots @wdconinc