Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EcalLumiSpecClusters collections #653

Merged
merged 6 commits into from
May 8, 2023
Merged

Fix EcalLumiSpecClusters collections #653

merged 6 commits into from
May 8, 2023

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 5, 2023 •
edited
Loading

Let's try to revert my changes and see if it helps.

Resolves: #652

@veprbl veprbl marked this pull request as draft May 5, 2023 16:03
@veprbl veprbl mentioned this pull request May 5, 2023
Closed
@dhevang dhevang self-assigned this May 5, 2023
@veprbl veprbl marked this pull request as ready for review May 5, 2023 22:49
@veprbl veprbl requested a review from dhevang May 5, 2023 22:49
@veprbl veprbl changed the title Test what broke EcalLumiSpecClusters collections Fix EcalLumiSpecClusters collections May 5, 2023
dhevang
dhevang approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@dhevang dhevang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error of missing collection was removed with this change.

@dhevang dhevang merged commit bc16d8c into main May 8, 2023
@dhevang dhevang deleted the pr/fix_652 branch May 8, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhevang dhevang dhevang approved these changes

Assignees

@dhevang dhevang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eicrecon-gcc-gun-EcalLumiSpec test is broken on main
2 participants
@veprbl @dhevang