refactor+fix: use collections and multi-factory in RichTrack_factory; fix potential leaks in TrackPropagation
#656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
c-dilks
changed the title
RichTrack_factoryRichTrack_factory
4 tasks
c-dilks
commented
May 7, 2023
c-dilks
force-pushed
the
rich-track-multifactory
branch
from
852c733 to
29fe147
Compare
7 tasks
c-dilks
changed the title
RichTrack_factoryRichTrack_factory; fix potential leaks in TrackPropagation
5 tasks
c-dilks
force-pushed
the
rich-track-multifactory
branch
from
1c9e1a8 to
b325164
Compare
c-dilks
force-pushed
the
rich-track-multifactory
branch
from
b325164 to
399c497
Compare
veprbl
reviewed
May 24, 2023
Possibly more at #661. |
c-dilks
force-pushed
the
rich-track-multifactory
branch
from
399c497 to
1c63180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
CollectionofTrackSegmentsinTrackPropagation::propagateToSurfaceList, rather than a (potentially leaky) newTrackSegmentpointerRichTrack_factorytoTrackPropagation::propagateToSurfaceList, which makes the PR diff appear to be more complex than it actually isreturn new raw_pointercalls withreturn std::make_unique<...>(...), and update any code which depends on this changeRichTrackConfig, which configures the factory, not the algorithm, since the factory is used to connect to therichgeoservice (and not the more generalTrackPropagationalgorithm)What kind of change does this PR introduce?
Please check if this PR fulfills the following:
irt-algobranchDoes this PR introduce breaking changes? What changes might users need to make to their code?
no, unless the
TrackPropagationalgorithm is called by anything external of EICreconDoes this PR change default behavior?
no