-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dRICH): merge track propagations #682
Conversation
2b52487
to
9d3ea5d
Compare
Since this adds a new algorithm, would you mind adding a unit test for it? They reside in src/tests/algorithms_test. |
36778a7
to
3f994e4
Compare
Sure, will do later today. On the other end of the testing spectrum, we have some preliminary benchmarks, which aim to test the full dRICH PID DAG. |
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
fix: add the test
3cf43dd
to
e04cac5
Compare
Unit tests added. |
cc @wdconinc |
Ha, thanks, and email notifications from eicweb should work again now :-) |
Briefly, what does this PR introduce?
pid
algorithms, since:tracking
algorithmsTrackSegments
TrackPoint
s (sorting them by time); we currently don't need the other members downstream for PIDpid
algorithms libraryplugin_add_*
calls needed for this PR, however, they will be needed for the full set ofpid
algorithms, so we might as well include them now (see feat!: add IRT PID to DRICH plugin #393)What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
no