Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dRICH): merge track propagations #682

Merged
merged 7 commits into from
Jun 2, 2023
Merged

feat(dRICH): merge track propagations #682

merged 7 commits into from
Jun 2, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented May 26, 2023

Briefly, what does this PR introduce?

  • Add an algorithm to merge propagated tracks from dRICH aerogel and gas.
  • Prefer to keep in pid algorithms, since:
    • avoid cluttering tracking algorithms
    • this is (currently) only used by PID, though it is a general algorithm for combining TrackSegments
    • it's incomplete, only combining the TrackPoints (sorting them by time); we currently don't need the other members downstream for PID
  • Add CMake file for pid algorithms library
    • there are more plugin_add_* calls needed for this PR, however, they will be needed for the full set of pid algorithms, so we might as well include them now (see feat!: add IRT PID to DRICH plugin #393)

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

no

Base automatically changed from rich-track-multifactory to main May 29, 2023 15:26
@c-dilks c-dilks mentioned this pull request May 29, 2023
30 tasks
@c-dilks c-dilks force-pushed the rich-merge-tracks branch from 2b52487 to 9d3ea5d Compare May 29, 2023 17:24
@c-dilks c-dilks marked this pull request as ready for review May 29, 2023 17:55
@c-dilks c-dilks requested a review from veprbl May 29, 2023 17:56
@veprbl
Copy link
Member

veprbl commented May 31, 2023

Since this adds a new algorithm, would you mind adding a unit test for it? They reside in src/tests/algorithms_test.

@c-dilks c-dilks force-pushed the rich-merge-tracks branch from 36778a7 to 3f994e4 Compare June 1, 2023 14:50
@c-dilks
Copy link
Member Author

c-dilks commented Jun 1, 2023

Since this adds a new algorithm, would you mind adding a unit test for it? They reside in src/tests/algorithms_test.

Sure, will do later today.

On the other end of the testing spectrum, we have some preliminary benchmarks, which aim to test the full dRICH PID DAG.

@c-dilks c-dilks force-pushed the rich-merge-tracks branch from 3cf43dd to e04cac5 Compare June 1, 2023 22:37
@c-dilks
Copy link
Member Author

c-dilks commented Jun 1, 2023

Unit tests added.

@c-dilks c-dilks requested a review from veprbl June 1, 2023 22:39
@veprbl
Copy link
Member

veprbl commented Jun 2, 2023

On the other end of the testing spectrum, we have some preliminary benchmarks, which aim to test the full dRICH PID DAG.

cc @wdconinc

@wdconinc
Copy link
Contributor

wdconinc commented Jun 2, 2023

On the other end of the testing spectrum, we have some preliminary benchmarks, which aim to test the full dRICH PID DAG.

cc @wdconinc

Ha, thanks, and email notifications from eicweb should work again now :-)

@c-dilks
Copy link
Member Author

c-dilks commented Jun 2, 2023

@veprbl thanks for a8aacea... seems I messed up that rebase conflict.

@c-dilks c-dilks merged commit 8050426 into main Jun 2, 2023
@c-dilks c-dilks deleted the rich-merge-tracks branch June 2, 2023 01:46
@c-dilks c-dilks self-assigned this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants