feat: CalorimeterHitsMerger factory simplification #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
force-pushed
the
calorimeter-hit-reco-config
branch
2 times, most recently
from
1ca0bc3 to
0638e36
Compare
wdconinc
force-pushed
the
calorimeter-hits-merger-config
branch
from
e98d9d1 to
5942b64
Compare
|
Only collection ID changes in output, https://github.com/eic/EICrecon/actions/runs/5678398028/job/15389068763?pr=803#step:11:71. |
wdconinc
force-pushed
the
calorimeter-hits-merger-config
branch
from
5942b64 to
9c7d781
Compare
This applies the #666 treatment to the CalorimeterHitsMerger algorithms: - put all configuration in a single configuration struct for use with WithPodConfig mixin, - create a templated factory-factory to use in the plugins, - replace all old explicit CalorimeterHit factories with the new factory-factory.
wdconinc
force-pushed
the
calorimeter-hits-merger-config
branch
from
9c7d781 to
f246571
Compare
veprbl
reviewed
Jul 28, 2023
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
veprbl
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This applies the #666 treatment to the CalorimeterHitsMerger algorithms:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.