fix: enable rpath on build and install linking #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
9 tasks
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
veprbl
previously approved these changes
Sep 11, 2023
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
veprbl
approved these changes
Sep 11, 2023
|
Sounds a bit like this experimental feature in spack: https://spack.readthedocs.io/en/latest/config_yaml.html#shared-linking-bind That is something we've looked into because of the cvmfs-mounted singularity images. Why link against a remote filesystem's generic /use/local/lib (even as rpath) when you can avoid the directory lookup with a direct path? I haven't looked into how it is implemented, but I think it's some elfutils rewriting that is needed. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
### Briefly, what does this PR introduce? Allow to create shared instead of static algorithms libraries, and allow skipping the creation of an algorithms plugin. Depends on: - [x] #942 (cherry-picked) - [x] #938 (cherry-picked) ### What kind of change does this PR introduce? - [x] Bug fix (issue #628 again) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Enable rpath/runpath linking. The goal of this PR is to add the dependency libraries (JANA, podio, EDM4hep, EDM4eic) with their paths into rpath and runpath, and to have all internal library dependencies be explicit as well. Ultimately, no LD_LIBRARY_PATH should need to be set.
And the same on MacOS...
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.