Implement geometry volumes for fiber grids in BEMC ScFi #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: barrel
|
Working on a visualization script for showing grid/fibers on local X-Z plane |
|
It's a part of the solution to eic/EICrecon#499 |
github-actions
bot
added
the
topic: infrastructure
github-actions
bot
added
the
topic: infrastructure
|
The geometry visualization script is done |
|
The same type of plot with different stave and layer (check title) |
|
Add more adjacent layers/grids in the visualization script to check the geometry. |
|
This PR is probably ready, but I will test it with some changes for CalorimeterHitRec in EICRecon and then request to merge both of them together. |
|
Caught a minor issue with fiber alignment between adjacent layers. Fixed as |
7 tasks
wdconinc
requested changes
Feb 21, 2023
wdconinc
reviewed
Feb 21, 2023
wdconinc
approved these changes
Feb 21, 2023
|
@Chao1009 When you're ready, you should be able to click automerge and update the branch to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
It adds geometry for grids so we can retrieve the position/dimension of a grid during the digitization/reconstruction.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No, it updates the internal behavior of geometry construction for the BarrelCalorimeterInterlayers. It does not change any of the interfaces to use it.
Does this PR change default behavior?
No.