Prevent unexisting aliases

[mfolkeseth]

Fixes eik-lib/issues#10

[trygve-lie]

Great. Thanks for this :)

There is a fair bit of lint adjustments here, can you give a short description of what the changes are? Also for the sake of the release notes.

[trygve-lie]

It was basically missing a validation of the version if I read this correctly. Right?

[mfolkeseth]

That is correct. It does a check for package version before the alias is updated 👍

Also, I gave you an @ for the entry point for the fix.

[trygve-lie]

I guess this adds a 400 - BadRequest to the alias POST documentation: https://eik.dev/docs/server_rest_api#update-alias

[trygve-lie]

Are you able to update the tests?

[mfolkeseth]

It leaves a throw new HttpError.NotFound(); - 404 error to follow the flow of the cli https://github.com/eik-lib/cli/blob/master/classes/alias.js#L101. In which case no doc update is needed. IMO the API and CLI feedback is just fine, just missing this additional package version check.

Yes, I will absolutely add some tests. I also think it would be beneficial to pull back the lint fix in this PR to keep it more clean.

[trygve-lie]

It leaves a throw new HttpError.NotFound(); - 404 error to follow the flow of the cli https://github.com/eik-lib/cli/blob/master/classes/alias.js#L101. In which case no doc update is needed. IMO the API and CLI feedback is just fine, just missing this additional package version check.

The API and CLI seems to be fine but there is a new status code in the POST method not reflected in the doc but I can check and update the doc when this is merged :)

Yes, I will absolutely add some tests.

Seems like there is just two tests failing due to the change in the returned http status code so it should be to just alter the status code in the tests.

If your able to add a test for the version check its great 👍

I also think it would be beneficial to pull back the lint fix in this PR to keep it more clean.

That would be great but might break the build. If it does its no stress. I see whats done here.

[mfolkeseth]

One small alteration to the implementation; I thought it would make more sense to just check if <version>.package.json exists. The implementation does not check the contents if this file anyway.

Also, I added the <version>.package.json to test sink for existing tests and did a separate test for cases where the package origin file does not exist.

As for the release notes:

• Make sure package version exists before creating/updating alias.

[trygve-lie]

Looks good to me 👍

[github-actions]

🎉 This PR is included in version 1.2.24 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[trygve-lie]

Released :) We depend on semantic release and renovate bot for auto release and dependency updates in this project so it should propagate to the service module by it self soon.