-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add khmer lang #2012
add khmer lang #2012
Conversation
currently I am trying to run test by doing
any ideas on where to increase the timeout or something went wrong so it took that long? |
Hi @xshadowlegendx thank you very much! I don't have time to take a deeper look until the weekend, but it looks well done! I don't know why the tests can't get a lock for mariadb… really strange. But that is not related to your change, so it's fine. |
For the scala-format errors, you can run |
hello @eikek, ok I will run |
hello @eikek, I ran the test again and I think the timeout is due to my computer running slow I guess, I tried restarting and ran it again then no timeout issue anymore but this one
|
hello @eikek, so I ran so question is how do I able to test changes I have made locally using docker or build the edit0: oh sorry, forgot to read this page which say how to make those zips edit1: update comment to include approach to build zip locally then modify dockerfiles to build locally for testing |
hello @eikek , I have tested the changes by
edit0: those document that were used for testing are docx, text pdf and pdf with scanned image |
Thank you very much for this comprehensive testing @xshadowlegendx !
The issue here is that you need to pass it as one single argument to sbt, so just quote it like
This commands builds new dockerimages, but it downloads the prebuild zip files from github using the given version (here
I suspect there is a font missing on the system. This is always a bit tricky to find out. SOLR: |
hello @eikek, |
for the font missing part, I will try to investigate about it |
Thank you! I suspected it would add optional code to SOLR. The consequence is now that this affects every user that runs SOLR not via docker. Perhaps it would be good to mention it in the docs, maybe here. |
yes, I will help update the docs as well |
hello @eikek, I have edited the docs, but how do I see my changes locally? |
There is a bit in the website readme here. The |
ok thanks @eikek, I will try to run it |
hello @eikek, running
and
|
@xshadowlegendx You might need to use an older version, like 0.14.1 should work (that is used by ci) |
hello @eikek, is it |
Sorry for the delay! I meant the version of zola. The errors are coming from zola if I understand correctly. It happens that newer versions have more checks or other changes that require to revisit the pages. Using 0.14.1 should work. |
I have tried using
I think the error is about missing files? not sure but the output seems to indicate so |
So I went to check those file that the program is expecting and it wasnt there, those seems to be config files, so I tried copying
do I have to get those files from somewhere? |
@xshadowlegendx Yes so these files are in the source root, because they are used within the application. The build tool copies them in the appropriate place when creating the website. I think the easiest is to run |
@eikek ok thanks, I will try it again |
hello @eikek what do you think about this |
regarding to this, I have confirmed that it is the missing font issue, so I exec into
after the font is installed edit0: fixed grammar |
Thank you @xshadowlegendx for all your efforts! |
hello @eikek thank you as well for your amazing work on this project, do u think the docs is good to be pushed? |
Yes sure, that is good! I left a small 'thumbs up" 😄 You don't need to bother about the dead link in the docs. Sadly some site has been taken offline. |
@eikek oh haha sorry did not notice the "thumbs up", thanks you very much |
this pr contains
solr
indocker-compose.yml
to enableanalysis-extras
module foricu
tokenizerKhmer
lang according to the guide but skip the adding test stepsolr
in https://docspell.org/docs/install/prereq/ that also needextra-analysis
module in order for text analysis to be working forkhmer
languagejoex.dockerfile
to add khmer font and tesseract khmer model