-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CJK and Custom Mapping Documentation #2669
Conversation
…ical-support Merging in master branch.
…tainer. Co-Authored-By: eikek <eike.kettner@posteo.de>
…al-support' into add-japanese-vertical-support
…apanese-vertical-support
…npai-git/docspell into add-japanese-vertical-support
…apanese-vertical-support
…npai-git/docspell into add-japanese-vertical-support
Hi @tenpai-git - since this feature is part of the next release, this documentation update should target the master branch. As you can see, this PR contains many commits from master, that you didn't create :-) The |
Sorry about that @eikek - I switched to the correct target now! I was targeting current-docs last time because of the last documentation I worked on, but in hindsight, that was to clarify an issue in the current release and like you said this is for next release. There is an additional change left over in this branch but it should be identical to the previous one I made yesterday. I think we're all good now and I'm looking forward to being apart of the next release! |
No reason to be sorry! Thanks for updating. If you think this is now good to go, I'll try to find some time to do the next release. |
Yup, it should be all good as far as I can tell. Japanese Vertical language option, the custom mappings you did, and improved support for optical character recognition I think should all be listed along with all the dependency updates to resolve other's issues is probably worth a major release. Hopefully the major release posting helps other CJK-users realize that the support is there for them to build on. Can come back to vertical Korean/Chinese at a later point or another person proficient in those languages can easily use this as a basis to add them. This has been a pleasure to work on because you've been such a great maintainer @eikek - thank you for everything!!! |
Thank you @tenpai-git, it was my pleasure! |
This resolves #2667 item 3 to add documentation for custom mapping documentation and follow-ups for working with vertical language outputs.