Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize file and add new icon #6

Merged
merged 3 commits into from
Feb 6, 2018
Merged

organize file and add new icon #6

merged 3 commits into from
Feb 6, 2018

Conversation

bnandhakumar18
Copy link
Contributor

Hi. I was planning to suggest that an icon to be added myself, but you beat me to it. :)
anyways, I have slightly reorganised the folder structure and have provided my icon suggestion as well.
Hopeyou like it...

P.S. great work on adding snippets, love them

@eirikpre
Copy link
Owner

eirikpre commented Feb 4, 2018

I like your icon, I think it's better than mine.
I think we can change to yours, but I would like to ask you one thing; crop it :)
The extension browser doesn't automatically crop the icon, which leads to it being very small if there is empty space around it

@bnandhakumar18
Copy link
Contributor Author

can you provide the resolution to which I should crop it?

@bnandhakumar18
Copy link
Contributor Author

also please indicate if it is possible to add a favicon to the extension, so that it appears on the tabs in which .sv/.v files are opened?
cause that would look nice too

@eirikpre
Copy link
Owner

eirikpre commented Feb 5, 2018

I think around 500x500 is a good resolution, that way it looks good when the extension page is opened. eg Python uses 600x600.

I have looked into the favicon, I would really like that as well.
However, it's not available in VSCode (yet), see this issue
What you have to do for it to work is add an entire icon theme, but I don't think that's a good idea.
I have added a recommendation in the README for an Icon theme that includes icons for .sv / .v

@bnandhakumar18
Copy link
Contributor Author

excellent, will get back to you with the cropped image

@bnandhakumar18
Copy link
Contributor Author

hi I have updated the icon to 500 x 500 now

@eirikpre
Copy link
Owner

eirikpre commented Feb 6, 2018

Nice, merging it in, poke me if I forget to change the logo in the next minor release (0.3.0)
Did you get to try typescript yet? ( was it easy to get it running )?

@eirikpre eirikpre merged commit 720dd2e into eirikpre:master Feb 6, 2018
@bnandhakumar18
Copy link
Contributor Author

not yet..been busy with other chores..although, will try soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants