fix: yarn berry detection in case working directory is changed #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furthermore, prevent errors in case of berry usage and attempt to add arguments, which are not supported by berry.
eirslett
reviewed
May 12, 2024
Support Java 8 still
eirslett
reviewed
May 12, 2024
Java 11 (because Java 8 causes issues on GitHub Actions)
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In case the workingDirectory option is used the detection of yarn berry does not work properly:
To fix that the workingDirectory needs to be included for the .yarnrc.yml file detection
As a workaround it is possible to add an empty .yarnrc.yml file into the module root directory.
Furthermore, I forwarded the is berry check to the runner, so that additional arguments are not set, which are not supported by yarn berry.
Tests and Documentation
I updated the workflows, because they complained because of outdated and not supported node versions and updated the java version, because the mac os run complained that Java 8 is not supported anymore.
Furthermore, I added a test for yarn berry.