Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1152: Copy npm script file #1153

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Jun 7, 2024

Summary

Fix #1152: Copy npm script file

As mentioned in the ticket the comment said it was copying the script and it was not.

Originally reported on Quarkus Quinoa: quarkiverse/quarkus-quinoa#683

@eirslett
Copy link
Owner

Should it be copying "npx" and "npx.cmd" as well?

@melloware

This comment was marked as outdated.

@melloware
Copy link
Contributor Author

Updated to copy "npx" and "npx.cmd" as well

@melloware
Copy link
Contributor Author

Bump

@eirslett
Copy link
Owner

eirslett commented Sep 9, 2024

Ah yeah, sorry, thanks!

@eirslett eirslett merged commit a7d3b8b into eirslett:master Sep 9, 2024
3 checks passed
@melloware melloware deleted the patch-1 branch September 9, 2024 11:44
@melloware
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeInstaller is not copying the npm binaries next to the node exec
2 participants