-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing the usage of custom keybinds set by user to switch windows #88
Merged
ejbills
merged 16 commits into
ejbills:keybind
from
hasansultan92:feature/key-combination-dropdown
Jul 8, 2024
Merged
Introducing the usage of custom keybinds set by user to switch windows #88
ejbills
merged 16 commits into
ejbills:keybind
from
hasansultan92:feature/key-combination-dropdown
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hasansultan92 I'm curious why you didn't use https://github.com/sindresorhus/KeyboardShortcuts? |
@ShlomoCode good question! I had a couple of reasons to stay away from this
|
ejbills
added a commit
that referenced
this pull request
Jul 8, 2024
* Introducing the usage of custom keybinds set by user to switch windows (#88) * generate appcast script * Create draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Adding Setting pane to toggle window switcher * Addition of segmented picker * Initial Segmented Picker implementation * HotFix: Application was crashing when new user would launch * fallback assignment * Enabling usage of custom user keybinds * Deprecate use of UserDefaults in favor of Defaults * Remove: draft_release.yml --------- Co-authored-by: Ethan Bills <ethanjacksonbills@gmail.com> Co-authored-by: ejbills <74191134+ejbills@users.noreply.github.com> * fix window view * fix window title --------- Co-authored-by: Hasan Sultan <52581466+hasansultan92@users.noreply.github.com>
@ejbills Why does it go in as commit "v1.0.16"? In this way it will be terrible in the future to investigate changes in the git history :( |
ejbills
added a commit
that referenced
this pull request
Jul 8, 2024
* Introducing the usage of custom keybinds set by user to switch windows (#88) * generate appcast script * Create draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Update draft_release.yml * Adding Setting pane to toggle window switcher * Addition of segmented picker * Initial Segmented Picker implementation * HotFix: Application was crashing when new user would launch * fallback assignment * Enabling usage of custom user keybinds * Deprecate use of UserDefaults in favor of Defaults * Remove: draft_release.yml --------- Co-authored-by: Ethan Bills <ethanjacksonbills@gmail.com> Co-authored-by: ejbills <74191134+ejbills@users.noreply.github.com> * fix window view * fix window title --------- Co-authored-by: Hasan Sultan <52581466+hasansultan92@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #11. Instructions to follow setting a custom user keybind is as follows and can be found in the updated readme as well:
Record Keybind
buttonPlease ignore the branch name, the intial idea was to have a dropdown but settled for a segmented picker view instead
The default key bind for the window switcher for DockDoor is now CMD + Tab, replacing the default Mac OS window switcher unless otherwise programmed by the user.