Skip to content

Commit

Permalink
[code] Don't show goals type when details are closed.
Browse files Browse the repository at this point in the history
This is a workaround for #525 #652

For now, I disable this setting, so types are not displayed.

The right fix would be to add a checkbox in the view, so this can be
toggled dynamically, but I don't have the cycles for that right now,
and not worth delaying the release which is long overdue.
  • Loading branch information
ejgallego committed May 28, 2024
1 parent c691c52 commit 7a78aa7
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions editor/code/views/info/Goals.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,24 @@ function Goal({ goal, idx, open }: GoalP) {
}
});

// XXX: We want to add an option for this that can be set interactively
let show_goal_on_header = false;

let gtyp = (
<div style={{ marginLeft: "1ex" }} className={className} ref={tyRef}>
<CoqPp content={goal.ty} inline={false} />
</div>
);

return (
<div className="coq-goal-env" ref={ref}>
<Details summary={`Goal (${idx})`} open={open}>
<div style={{ paddingTop: "1ex" }} />
<Hyps hyps={goal.hyps} />
<hr />
{show_goal_on_header ? "" : gtyp}
</Details>
<div style={{ marginLeft: "1ex" }} className={className} ref={tyRef}>
<CoqPp content={goal.ty} inline={false} />
</div>
{show_goal_on_header ? gtyp : ""}
</div>
);
}
Expand Down

0 comments on commit 7a78aa7

Please sign in to comment.