[client] Server status icon will now react properly to fatal server errors #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
added
kind: enhancement
ejgallego
force-pushed
the
disable_on_not_found
branch
from
6833d2d to
4c8e2c2
Compare
Alizter
reviewed
Feb 21, 2023
editor/code/src/client.ts
Outdated
| @@ -239,6 +244,14 @@ export function activate(context: ExtensionContext): void { | |||
| } | |||
| }; | |||
|
|
|||
| const setFailedStatuBar = (emsg: string) => { | |||
| lspStatusItem.text = "$(circle-slash) coq-lsp (client failed to start)"; | |||
There was a problem hiding this comment.
Suggested change
| lspStatusItem.text = "$(circle-slash) coq-lsp (client failed to start)"; | |
| lspStatusItem.text = "$(circle-slash) coq-lsp (error)"; |
The tooltip should be enough. The recommendation is not to take up to much space.
There was a problem hiding this comment.
I see, but I find error too generic, what error? As this is the "exceptional" case, IMHO it is fine to be a bit longer, but I hear your concern.
Actually the message is wrong, it is the server that failed.
There was a problem hiding this comment.
Made it a bit shorter, thanks!
…rrors Clicking on it will try to restart the server which is IMO a good thing. Fixes #399
ejgallego
force-pushed
the
disable_on_not_found
branch
from
4c8e2c2 to
6f7a756
Compare
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Feb 22, 2023
CHANGES: --------------------- - The info / goal view now uses jsCoq's client-side rendering, with better highlighting and layout rendering (@artagnon, @ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#96) - Printing method is now configurable by the user (@ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#321) - Trigger completion on quote char "'" (@ejgallego, ejgallego/coq-lsp#350) - Fix typo on keybinding config for show goals (@tomtomjhj, ejgallego/coq-lsp#357) - New request `coq/getDocument` to get serialized full document contents. Thanks to Clément Pit-Claudel for feedback and ideas. (@ejgallego, ejgallego/coq-lsp#350) - Auto-ignore Coq object files; can be disabled in config (@ejgallego, ejgallego/coq-lsp#365) - Support workspaces with multiple roots, this is very useful for projects that contain several `_CoqProject` files in different directories (@ejgallego, ejgallego/coq-lsp#374) - Add VS Code commands to start / stop the server (@ejgallego, ejgallego/coq-lsp#377, cc ejgallego/coq-lsp#209) - Fix bug that made the server not exit on `exit` LSP notification (@artagnon, @ejgallego, ejgallego/coq-lsp#375, fixes ejgallego/coq-lsp#230) - Lay the foundation for server tests (@artagnon, ejgallego/coq-lsp#356) - Remove the `coq-lsp.ok_diagnostics` setting (@artagnon, ejgallego/coq-lsp#129) - Print abbreviations on hover (@ejgallego, ejgallego/coq-lsp#384) - Print hover types without parenthesis (@ejgallego, ejgallego/coq-lsp#384) - Parse identifiers with dot for hover and jump to definition (@ejallego, ejgallego/coq-lsp#385) - Update `vscode-languageclient` to 8.1.0 (@ejgallego, @Alizter, ejgallego/coq-lsp#383, fixes ejgallego/coq-lsp#273) - Fix typo on max_errors checking, this made coq-lsp stop on the number of total diagnostics, instead of only errors (@ejgallego, ejgallego/coq-lsp#386) - Hover symbol information: hypothesis names must shadow globals of the same name (@ejgallego, ejgallego/coq-lsp#391, fixes ejgallego/coq-lsp#388) - De-schedule document on didClose, otherwise the scheduler will keep trying to resume it if it didn't finish (@ejgallego, ejgallego/coq-lsp#392) - Hover symbol information: correctly handle identifiers before '.' and containing a quote (') themselves (@ejgallego, ejgallego/coq-lsp#393) - Add children entries to the table-of-contents (@ejgallego, ejgallego/coq-lsp#394) - Invalidate Coq's imperative cache on error (@ejgallego, @r-muhairi, ejgallego/coq-lsp#395) - Add status bar button to toggle server run status (@ejgallego, @Alizter, ejgallego/coq-lsp#378, closes ejgallego/coq-lsp#209) - Support for `COQLIB` and `COQCORELIB` environment variables, added `--coqcorelib` command line argument (@ejgallego, ejgallego/coq-lsp#403) - Protocol infrastructure for code lenses (@ejgallego, ejgallego/coq-lsp#396) - Set binary more for protocol input / output (@ejgallego, ejgallego/coq-lsp#408) - Allow to set `ocamlpath` from the command line (@ejgallego, ejgallego/coq-lsp#408) - Windows support (@ejgallego, @jim-portegies, ejgallego/coq-lsp#408) - Scroll active goal into view (@ejgallego, ejgallego/coq-lsp#410, fixes ejgallego/coq-lsp#381) - Server status icon will now react properly to fatal server errors (@ejgallego, reported by @Alizter, ejgallego/coq-lsp#411, fixes ejgallego/coq-lsp#399) - Info on memory and time is now disabled by default, new option `coq-lsp.stats_on_hover_option` to re-enable it (@ejgallego, ejgallego/coq-lsp#412, fixes ejgallego/coq-lsp#398). - `coq-lsp` can now save `.vo` files for files opened in the editor. Use the new "Save to .vo" command, or the new protocol `coq/saveVo` request (@ejgallego, ejgallego/coq-lsp#417, fixes ejgallego/coq-lsp#339)
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Feb 22, 2023
CHANGES: --------------------- - The info / goal view now uses jsCoq's client-side rendering, with better highlighting and layout rendering (@artagnon, @ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#96) - Printing method is now configurable by the user (@ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#321) - Trigger completion on quote char "'" (@ejgallego, ejgallego/coq-lsp#350) - Fix typo on keybinding config for show goals (@tomtomjhj, ejgallego/coq-lsp#357) - New request `coq/getDocument` to get serialized full document contents. Thanks to Clément Pit-Claudel for feedback and ideas. (@ejgallego, ejgallego/coq-lsp#350) - Auto-ignore Coq object files; can be disabled in config (@ejgallego, ejgallego/coq-lsp#365) - Support workspaces with multiple roots, this is very useful for projects that contain several `_CoqProject` files in different directories (@ejgallego, ejgallego/coq-lsp#374) - Add VS Code commands to start / stop the server (@ejgallego, ejgallego/coq-lsp#377, cc ejgallego/coq-lsp#209) - Fix bug that made the server not exit on `exit` LSP notification (@artagnon, @ejgallego, ejgallego/coq-lsp#375, fixes ejgallego/coq-lsp#230) - Lay the foundation for server tests (@artagnon, ejgallego/coq-lsp#356) - Remove the `coq-lsp.ok_diagnostics` setting (@artagnon, ejgallego/coq-lsp#129) - Print abbreviations on hover (@ejgallego, ejgallego/coq-lsp#384) - Print hover types without parenthesis (@ejgallego, ejgallego/coq-lsp#384) - Parse identifiers with dot for hover and jump to definition (@ejallego, ejgallego/coq-lsp#385) - Update `vscode-languageclient` to 8.1.0 (@ejgallego, @Alizter, ejgallego/coq-lsp#383, fixes ejgallego/coq-lsp#273) - Fix typo on max_errors checking, this made coq-lsp stop on the number of total diagnostics, instead of only errors (@ejgallego, ejgallego/coq-lsp#386) - Hover symbol information: hypothesis names must shadow globals of the same name (@ejgallego, ejgallego/coq-lsp#391, fixes ejgallego/coq-lsp#388) - De-schedule document on didClose, otherwise the scheduler will keep trying to resume it if it didn't finish (@ejgallego, ejgallego/coq-lsp#392) - Hover symbol information: correctly handle identifiers before '.' and containing a quote (') themselves (@ejgallego, ejgallego/coq-lsp#393) - Add children entries to the table-of-contents (@ejgallego, ejgallego/coq-lsp#394) - Invalidate Coq's imperative cache on error (@ejgallego, @r-muhairi, ejgallego/coq-lsp#395) - Add status bar button to toggle server run status (@ejgallego, @Alizter, ejgallego/coq-lsp#378, closes ejgallego/coq-lsp#209) - Support for `COQLIB` and `COQCORELIB` environment variables, added `--coqcorelib` command line argument (@ejgallego, ejgallego/coq-lsp#403) - Protocol infrastructure for code lenses (@ejgallego, ejgallego/coq-lsp#396) - Set binary more for protocol input / output (@ejgallego, ejgallego/coq-lsp#408) - Allow to set `ocamlpath` from the command line (@ejgallego, ejgallego/coq-lsp#408) - Windows support (@ejgallego, @jim-portegies, ejgallego/coq-lsp#408) - Scroll active goal into view (@ejgallego, ejgallego/coq-lsp#410, fixes ejgallego/coq-lsp#381) - Server status icon will now react properly to fatal server errors (@ejgallego, reported by @Alizter, ejgallego/coq-lsp#411, fixes ejgallego/coq-lsp#399) - Info on memory and time is now disabled by default, new option `coq-lsp.stats_on_hover_option` to re-enable it (@ejgallego, ejgallego/coq-lsp#412, fixes ejgallego/coq-lsp#398). - `coq-lsp` can now save `.vo` files for files opened in the editor. Use the new "Save to .vo" command, or the new protocol `coq/saveVo` request (@ejgallego, ejgallego/coq-lsp#417, fixes ejgallego/coq-lsp#339)
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Apr 3, 2023
CHANGES: --------------------- - The info / goal view now uses jsCoq's client-side rendering, with better highlighting and layout rendering (@artagnon, @ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#96) - Printing method is now configurable by the user (@ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#321) - Trigger completion on quote char "'" (@ejgallego, ejgallego/coq-lsp#350) - Fix typo on keybinding config for show goals (@tomtomjhj, ejgallego/coq-lsp#357) - New request `coq/getDocument` to get serialized full document contents. Thanks to Clément Pit-Claudel for feedback and ideas. (@ejgallego, ejgallego/coq-lsp#350) - Auto-ignore Coq object files; can be disabled in config (@ejgallego, ejgallego/coq-lsp#365) - Support workspaces with multiple roots, this is very useful for projects that contain several `_CoqProject` files in different directories (@ejgallego, ejgallego/coq-lsp#374) - Add VS Code commands to start / stop the server (@ejgallego, ejgallego/coq-lsp#377, cc ejgallego/coq-lsp#209) - Fix bug that made the server not exit on `exit` LSP notification (@artagnon, @ejgallego, ejgallego/coq-lsp#375, fixes ejgallego/coq-lsp#230) - Lay the foundation for server tests (@artagnon, ejgallego/coq-lsp#356) - Remove the `coq-lsp.ok_diagnostics` setting (@artagnon, ejgallego/coq-lsp#129) - Print abbreviations on hover (@ejgallego, ejgallego/coq-lsp#384) - Print hover types without parenthesis (@ejgallego, ejgallego/coq-lsp#384) - Parse identifiers with dot for hover and jump to definition (@ejallego, ejgallego/coq-lsp#385) - Update `vscode-languageclient` to 8.1.0 (@ejgallego, @Alizter, ejgallego/coq-lsp#383, fixes ejgallego/coq-lsp#273) - Fix typo on max_errors checking, this made coq-lsp stop on the number of total diagnostics, instead of only errors (@ejgallego, ejgallego/coq-lsp#386) - Hover symbol information: hypothesis names must shadow globals of the same name (@ejgallego, ejgallego/coq-lsp#391, fixes ejgallego/coq-lsp#388) - De-schedule document on didClose, otherwise the scheduler will keep trying to resume it if it didn't finish (@ejgallego, ejgallego/coq-lsp#392) - Hover symbol information: correctly handle identifiers before '.' and containing a quote (') themselves (@ejgallego, ejgallego/coq-lsp#393) - Add children entries to the table-of-contents (@ejgallego, ejgallego/coq-lsp#394) - Invalidate Coq's imperative cache on error (@ejgallego, @r-muhairi, ejgallego/coq-lsp#395) - Add status bar button to toggle server run status (@ejgallego, @Alizter, ejgallego/coq-lsp#378, closes ejgallego/coq-lsp#209) - Support for `COQLIB` and `COQCORELIB` environment variables, added `--coqcorelib` command line argument (@ejgallego, ejgallego/coq-lsp#403) - Protocol infrastructure for code lenses (@ejgallego, ejgallego/coq-lsp#396) - Set binary mode for protocol input / output (@ejgallego, ejgallego/coq-lsp#408) - Allow to set `ocamlpath` from the command line (@ejgallego, ejgallego/coq-lsp#408) - Windows support (@ejgallego, @jim-portegies, ejgallego/coq-lsp#408) - Scroll active goal into view (@ejgallego, ejgallego/coq-lsp#410, fixes ejgallego/coq-lsp#381) - Server status icon will now react properly to fatal server errors (@ejgallego, reported by @Alizter, ejgallego/coq-lsp#411, fixes ejgallego/coq-lsp#399) - Info on memory and time is now disabled by default, new option `coq-lsp.stats_on_hover_option` to re-enable it (@ejgallego, ejgallego/coq-lsp#412, fixes ejgallego/coq-lsp#398). - `coq-lsp` can now save `.vo` files for files opened in the editor. Use the new "Save to .vo" command, or the new protocol `coq/saveVo` request (@ejgallego, ejgallego/coq-lsp#417, fixes ejgallego/coq-lsp#339)
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Apr 3, 2023
CHANGES: --------------------- - The info / goal view now uses jsCoq's client-side rendering, with better highlighting and layout rendering (@artagnon, @ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#96) - Printing method is now configurable by the user (@ejgallego, ejgallego/coq-lsp#143, fixes ejgallego/coq-lsp#321) - Trigger completion on quote char "'" (@ejgallego, ejgallego/coq-lsp#350) - Fix typo on keybinding config for show goals (@tomtomjhj, ejgallego/coq-lsp#357) - New request `coq/getDocument` to get serialized full document contents. Thanks to Clément Pit-Claudel for feedback and ideas. (@ejgallego, ejgallego/coq-lsp#350) - Auto-ignore Coq object files; can be disabled in config (@ejgallego, ejgallego/coq-lsp#365) - Support workspaces with multiple roots, this is very useful for projects that contain several `_CoqProject` files in different directories (@ejgallego, ejgallego/coq-lsp#374) - Add VS Code commands to start / stop the server (@ejgallego, ejgallego/coq-lsp#377, cc ejgallego/coq-lsp#209) - Fix bug that made the server not exit on `exit` LSP notification (@artagnon, @ejgallego, ejgallego/coq-lsp#375, fixes ejgallego/coq-lsp#230) - Lay the foundation for server tests (@artagnon, ejgallego/coq-lsp#356) - Remove the `coq-lsp.ok_diagnostics` setting (@artagnon, ejgallego/coq-lsp#129) - Print abbreviations on hover (@ejgallego, ejgallego/coq-lsp#384) - Print hover types without parenthesis (@ejgallego, ejgallego/coq-lsp#384) - Parse identifiers with dot for hover and jump to definition (@ejallego, ejgallego/coq-lsp#385) - Update `vscode-languageclient` to 8.1.0 (@ejgallego, @Alizter, ejgallego/coq-lsp#383, fixes ejgallego/coq-lsp#273) - Fix typo on max_errors checking, this made coq-lsp stop on the number of total diagnostics, instead of only errors (@ejgallego, ejgallego/coq-lsp#386) - Hover symbol information: hypothesis names must shadow globals of the same name (@ejgallego, ejgallego/coq-lsp#391, fixes ejgallego/coq-lsp#388) - De-schedule document on didClose, otherwise the scheduler will keep trying to resume it if it didn't finish (@ejgallego, ejgallego/coq-lsp#392) - Hover symbol information: correctly handle identifiers before '.' and containing a quote (') themselves (@ejgallego, ejgallego/coq-lsp#393) - Add children entries to the table-of-contents (@ejgallego, ejgallego/coq-lsp#394) - Invalidate Coq's imperative cache on error (@ejgallego, @r-muhairi, ejgallego/coq-lsp#395) - Add status bar button to toggle server run status (@ejgallego, @Alizter, ejgallego/coq-lsp#378, closes ejgallego/coq-lsp#209) - Support for `COQLIB` and `COQCORELIB` environment variables, added `--coqcorelib` command line argument (@ejgallego, ejgallego/coq-lsp#403) - Protocol infrastructure for code lenses (@ejgallego, ejgallego/coq-lsp#396) - Set binary mode for protocol input / output (@ejgallego, ejgallego/coq-lsp#408) - Allow to set `ocamlpath` from the command line (@ejgallego, ejgallego/coq-lsp#408) - Windows support (@ejgallego, @jim-portegies, ejgallego/coq-lsp#408) - Scroll active goal into view (@ejgallego, ejgallego/coq-lsp#410, fixes ejgallego/coq-lsp#381) - Server status icon will now react properly to fatal server errors (@ejgallego, reported by @Alizter, ejgallego/coq-lsp#411, fixes ejgallego/coq-lsp#399) - Info on memory and time is now disabled by default, new option `coq-lsp.stats_on_hover_option` to re-enable it (@ejgallego, ejgallego/coq-lsp#412, fixes ejgallego/coq-lsp#398). - `coq-lsp` can now save `.vo` files for files opened in the editor. Use the new "Save to .vo" command, or the new protocol `coq/saveVo` request (@ejgallego, ejgallego/coq-lsp#417, fixes ejgallego/coq-lsp#339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on it will try to restart the server which is IMO a good thing.
Fixes #399