[hover] Pass implicit information to printer. #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows what Coq's `About` does upstream. Note that still the printing is not very satisfactory in some cases, but in this case it seems Coq's `About` has the same problem. So I'd suggest to close #448 and open an issue upstream about general implicit argument printing, WDYT @Alizter ? Fixes #448.
ejgallego
added
kind: enhancement
|
Yes, feel free to generalise the issue. |
|
Ok, I don't have the time this week to research the printing problems upstream, but added to a TODO list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows what Coq's
Aboutdoes upstream.Note that still the printing is not very satisfactory in some cases, but in this case it seems Coq's
Abouthas the same problem.So I'd suggest to close #448 and open an issue upstream about general implicit argument printing, WDYT @Alizter ?
Fixes #448.