Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the description of refactor commit type #41

Closed
YoPoulou opened this issue Oct 8, 2024 · 1 comment
Closed

Improve the description of refactor commit type #41

YoPoulou opened this issue Oct 8, 2024 · 1 comment
Labels
A:Config Area: Config T:Change Type: Change request
Milestone

Comments

@YoPoulou
Copy link

YoPoulou commented Oct 8, 2024

In the git-z.toml file describing the different type of commit, the term refactor is defined as a tautology. Instead we could use a real definition. E.g. in wikipedia : "A code refactor is a proccess of restructuring existint source code without changing its external behavior".

Source : https://en.m.wikipedia.org/wiki/Code_refactoring

@ejpcmac ejpcmac added A:Config Area: Config T:Change Type: Change request labels Oct 8, 2024
@ejpcmac ejpcmac added this to the git-z 0.2.2 milestone Oct 8, 2024
@ejpcmac ejpcmac moved this from Backlog to Preparation in ejpcmac’s personal OSS work Dec 8, 2024
@ejpcmac ejpcmac moved this from Preparation to Ongoing in ejpcmac’s personal OSS work Dec 8, 2024
@ejpcmac
Copy link
Owner

ejpcmac commented Dec 8, 2024

I’m going for :

restructure the code without changing its external behaviour

@ejpcmac ejpcmac moved this from Ongoing to In Review in ejpcmac’s personal OSS work Dec 8, 2024
@ejpcmac ejpcmac moved this from In Review to Solved in ejpcmac’s personal OSS work Dec 8, 2024
@ejpcmac ejpcmac moved this from Solved to In Review in ejpcmac’s personal OSS work Dec 8, 2024
ejpcmac added a commit that referenced this issue Dec 8, 2024
@ejpcmac ejpcmac moved this from In Review to Solved in ejpcmac’s personal OSS work Dec 8, 2024
@ejpcmac ejpcmac closed this as completed Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:Config Area: Config T:Change Type: Change request
Projects
Status: Solved
Development

No branches or pull requests

2 participants