add support for unary not #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejrgilbert
reviewed
May 31, 2024
ejrgilbert
reviewed
Jun 3, 2024
| } | ||
| } | ||
| stmts | ||
| }); |
There was a problem hiding this comment.
Are you sure this works? Tracing through the logic, I think you're missing a .collect() or something to actually pull all the values together to have a complete vec of statements.
There was a problem hiding this comment.
I think I'm safe because I pushed them one by one here:
https://github.com/ejrgilbert/whamm/pull/29/files/6a05d42c900ac243fb6973aa1e4be50c66f7207b#diff-665de66fa07a44b55ab96803488e9d1f829f7fe1179c3e1aca83e81b999923f3R172
There was a problem hiding this comment.
Ahhh, it's mapping to the unwrapped Some contents and then iterating in the for loop. That makes sense.
|
Also, looks like merging your ast print visitor PR resulted in some merge conflicts here. |
|
Looks good! Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for unary operator not.
Also applied some cargo clippy changes.