Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target the http client interface instead of a concrete impl #54

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

PeeHaa
Copy link
Collaborator

@PeeHaa PeeHaa commented Sep 14, 2020

Fixes the following issue in #47 :

  • Instead of asking for a concrete HttpClient class maybe ask for an interface instead?

@ekinhbayar ekinhbayar merged commit cae98c3 into master Sep 16, 2020
@ekinhbayar ekinhbayar deleted the http-client-interface branch September 16, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants