Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dind] Feat : build arm64 docker image #849

Merged
merged 2 commits into from
Jul 25, 2023
Merged

[Dind] Feat : build arm64 docker image #849

merged 2 commits into from
Jul 25, 2023

Conversation

Bonnai2112
Copy link
Collaborator

@Bonnai2112 Bonnai2112 commented Jul 28, 2022 •
edited
Loading

Improvements

  • Dind : build arm64 docker image

Issue

  • aws: not found on arm64
  • The weird behavior that the install seems to fail at line 78 of the install script, but the install script seems to complete successfully, only to then fail when we try to actually run the installed bin. The bug discussion forum aws-cli-v2 issue with alpine using Docker aws/aws-cli#4971

@Bonnai2112 Bonnai2112 force-pushed the Dind-build-arm64-docker-image branch from 84a89ba to ed7655e Compare July 6, 2023 13:32
@Bonnai2112 Bonnai2112 mentioned this pull request Jul 10, 2023
Closed
@Bonnai2112 Bonnai2112 force-pushed the Dind-build-arm64-docker-image branch 3 times, most recently from 97e778f to 758b5fb Compare July 18, 2023 12:32
@Bonnai2112 Bonnai2112 changed the title [WIP][Dind] Feat : build arm64 docker image [Dind] Feat : build arm64 docker image Jul 18, 2023
@Bonnai2112 Bonnai2112 force-pushed the Dind-build-arm64-docker-image branch 3 times, most recently from 47a5d51 to dd56c5e Compare July 18, 2023 13:38
axelpavageau
axelpavageau reviewed Jul 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
axelpavageau
axelpavageau reviewed Jul 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Bonnai2112 Bonnai2112 force-pushed the Dind-build-arm64-docker-image branch from dd56c5e to a0cd059 Compare July 18, 2023 13:52
@Bonnai2112 Bonnai2112 force-pushed the Dind-build-arm64-docker-image branch from a0cd059 to 64e3577 Compare July 18, 2023 14:01
@axelpavageau axelpavageau merged commit 15f6ada into ekino:master Jul 25, 2023
3 checks passed
@axelpavageau axelpavageau mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelpavageau axelpavageau axelpavageau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bonnai2112 @axelpavageau