Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection to Pi-Hole(s) handled in goroutine #110

Merged
merged 19 commits into from
Feb 20, 2022
Merged

Connection to Pi-Hole(s) handled in goroutine #110

merged 19 commits into from
Feb 20, 2022

Conversation

Galorhallen
Copy link
Contributor

@Galorhallen Galorhallen commented Jan 5, 2022 •
edited
Loading

Hi,
in this PR:

  • Using goroutines to connect to multiple PI-Hole instances in parallel.
  • The unused interval configuration has been removed
  • Timeout configuration has been added, which controls the timeout to connect to a Pi-Hole instance.
  • Log library to handle log levels

eko and others added 14 commits December 30, 2021 00:43
@eko @Galorhallen
Fixed GitHub Actions go versions
cf04392
@Galorhallen
Add channel
8d55865
@Galorhallen
Add async metrics fetch for multiple piholes
7009c70 
parent 8d55865
author Galorhallen <andrea.ponte1987@gmail.com> 1640558190 +0100
committer Galorhallen <andrea.ponte1987@gmail.com> 1640821760 +0100

Add test for multiple pihole

Add async mode for multiple piholes

Fixed GitHub Actions go versions

Add test for multiple pihole

Cleanup
@Galorhallen
Woring on logging
2c062e5
@Galorhallen
Add channel
e4ddf5c
@Galorhallen
Add async metrics fetch for multiple piholes
bda504d 
parent 8d55865
author Galorhallen <andrea.ponte1987@gmail.com> 1640558190 +0100
committer Galorhallen <andrea.ponte1987@gmail.com> 1640821760 +0100

Add test for multiple pihole

Add async mode for multiple piholes

Fixed GitHub Actions go versions

Add test for multiple pihole

Cleanup
@Galorhallen
Merge branch 'master' into async
0d8f3ea
@Galorhallen
Merge branch 'master' into async
479456e
@Galorhallen
Fix error message
2a939bf
@Galorhallen
Removed 'interval' configuration. Add timeout
4381338
@Galorhallen
Updated docs
e521a90
@Galorhallen
Merge branch 'master' into async
7824dee
@Galorhallen
Fix go.mod
ea2e9ab
@Galorhallen
Fixed empty field in Config String function
ecfd7f7
@Galorhallen Galorhallen marked this pull request as ready for review January 30, 2022 10:24
@Galorhallen Galorhallen mentioned this pull request Feb 10, 2022
Open
eko
eko approved these changes Feb 20, 2022
View reviewed changes
Copy link
Owner

@eko eko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems great to me. Thanks for your work @Galorhallen

@eko eko merged commit 5ca2852 into eko:master Feb 20, 2022
@drupol drupol mentioned this pull request Feb 5, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eko eko eko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Galorhallen @eko