Added push=true to docker build output
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hed to the docker registry
eko
approved these changes
Jun 6, 2022
eko
force-pushed
the
master
branch
5 times, most recently
from
2565565 to
85925c8
Compare
|
Thank your for this addition @Zozman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #130 (and as seen in the lack of architecture tags in the Dockerhub listing for this image, it currently does not seem that every platform's docker builds are being uploaded to Dockerhub. Based on this comment in the buildx repo, it seems that
push=trueneeds to be added to force docker to push all the platforms to the registry, so have opened this PR to add it.If I am super wrong / have missed something obvious, feel free to eviscerate this PR as you see fit, you will not offend me :)