Update test matrix for supported go versions and add example docker-compose.yml #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tsunam
commented
Sep 23, 2021
tsunam
commented
Why do we need this change? ---- Go version 1.12 does not support the %w case which requires go >= 1.13. This resolves the build tests partially failing since 26ddc36 Additionally as we are upgrading to 1.17 for various things ensure that we test up to those latest version we support
Why do we need this change? ---- Give a practical docker-compose.yml example to make it easier for people to build and or run within their own compose setups What effects does this change have? ----
|
Hi @tsunam, Thank you for this upgrade :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.