This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Feature: 3DS method improvements #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vasylnahuliak @aris-paskalov Hey, I made a few changes to 3DS method, please review when you can 🙏 |
|
@audrius-sav Thanks! Released in v2.4.0 https://github.com/ekreative/react-native-braintree/releases/tag/v2.4.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues I came across with:
clientTokentorun3DSecureCheck()method. I don't think it should be mandatory, because if any of the Braintree methods were run before, Braintree client was already initialized. So fixed it in both iOS and Android and handled case where promise is rejected if no token is passedemail,firstname,lastnameand other 3DS fields, but actually they're not mandatory, you should just pass as many as you have. Made them optional