Skip to content

Commit

Permalink
fix: delete cluster should not freeze while waiting for nodegroups …
Browse files Browse the repository at this point in the history
…to be deleted

THis was due to a send/receive race-condition on an unbuffered golang channel. The waiter should run in a goroutine. Otherwise the waiter is unable to send to the errs channel, because there is no receiver yet.
  • Loading branch information
mumoshu committed Dec 26, 2018
1 parent da00fc9 commit 19f9f1f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cfn/manager/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ func (c *StackCollection) WaitDeleteStackTask(name string, errs chan error) erro

logger.Info("waiting for stack %q to get deleted", *i.StackName)

c.waitUntilStackIsDeleted(i, errs)
go c.waitUntilStackIsDeleted(i, errs)

return nil
}
Expand Down

0 comments on commit 19f9f1f

Please sign in to comment.