Skip to content

Commit

Permalink
Add missing defaulting logic and generated code
Browse files Browse the repository at this point in the history
  • Loading branch information
errordeveloper committed Mar 22, 2019
1 parent 74649b0 commit 42b63f4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/apis/eksctl.io/v1alpha4/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ func (c *ClusterConfig) NewNodeGroup() *NodeGroup {
AutoScaler: NewBoolFalse(),
ExternalDNS: NewBoolFalse(),
AppMesh: NewBoolFalse(),
EBSCSI: NewBoolFalse(),
},
},
}
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/eksctl.io/v1alpha4/validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ func validateNodeGroupIAM(i int, ng *NodeGroup, value, fieldName, path string) e
if v := ng.IAM.WithAddonPolicies.AppMesh; v != nil && *v {
return fmt.Errorf("%s.AppMesh cannot be set at the same time", p)
}
if v := ng.IAM.WithAddonPolicies.EBSCSI; v != nil && *v {
return fmt.Errorf("%s.ebsCSI cannot be set at the same time", p)
}
}
return nil
}
Expand Down
5 changes: 5 additions & 0 deletions pkg/apis/eksctl.io/v1alpha4/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/cfn/builder/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ var _ = Describe("CloudFormation template builder API", func() {
AutoScaler: api.NewBoolFalse(),
ExternalDNS: api.NewBoolFalse(),
AppMesh: api.NewBoolFalse(),
EBSCSI: api.NewBoolFalse(),
},
},
},
Expand Down

0 comments on commit 42b63f4

Please sign in to comment.