Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ASG size modification from eksctl #116

Closed
stevesloka opened this issue Jul 12, 2018 · 3 comments
Closed

Allow ASG size modification from eksctl #116

stevesloka opened this issue Jul 12, 2018 · 3 comments
Assignees
@richardcase
Labels
help wanted Extra attention is needed kind/feature New feature or request
Milestone
0.1.x – improvements

Comments

@stevesloka
Copy link

It would be helpful to have eksctl allow for updating the desired node count for a cluster. I have some dev workflows where I want to scale up my node counts and then scale back.

Command example:

$ eksctl edit cluster --nodes=5

Some tricky things that could happen are if the user wants to scale beyond the max defined in the ASG. Should eksctl return error or update the ASG to allow more instances?

I'm happy to work through a design and help implement some features if desired.
@errordeveloper
Copy link
Contributor

Thanks, this is definetly very useful feature we should add soon! I was thinking we need to add subcommand for nodegroups anyway, and this would fit nicely as eksctl scale nodegroup --cluster=<name> --nodes=5 [<nodeGroupName>] (inspired by kubectl scale deployment, of course).

@errordeveloper errordeveloper added kind/feature New feature or request help wanted Extra attention is needed labels Jul 13, 2018
@errordeveloper errordeveloper added this to the 0.1.x – improvements milestone Jul 23, 2018
@richardcase richardcase self-assigned this Sep 5, 2018
@richardcase
Copy link
Contributor

Looking at this now.

@richardcase richardcase mentioned this issue Sep 6, 2018
Closed
5 tasks
richardcase added a commit that referenced this issue Oct 13, 2018
@richardcase
Added nodegroup scaling
c4ff14e 
Initial version of nodegroup scaling has been added. This isn't fully
complete yet as scaling down from an ec2 instance point works
but the workloads are migrated (i.e. drained).

Issue #116

Signed-off-by: Richard Case <richard.case@outlook.com>
richardcase added a commit that referenced this issue Oct 15, 2018
@richardcase
Added nodegroup scaling
2b459d9 
Initial version of nodegroup scaling has been added. This scales
by modifying the CloudFormation template for the nodegroup. The
modified template is used to create a changeset that is then
executed.

When scaling down/in (i.e. reducing the number of nodes) we rely
solely on the the resulting change to the ASG. This means that
the node(s) that are to be terminated aren't drained and so pods
running on the terminating nodes may cause errors. In the future
we may consider picking the EC2 instances to be terminated and then
drain the nodes and then create a termination policy to ensure those
nodes are killed.

Issue #116

Signed-off-by: Richard Case <richard.case@outlook.com>
@richardcase richardcase mentioned this issue Oct 15, 2018
Merged
9 tasks
richardcase added a commit that referenced this issue Oct 15, 2018
@richardcase
Added nodegroup scaling
cc9c25b 
Initial version of nodegroup scaling has been added. This scales
by modifying the CloudFormation template for the nodegroup. The
modified template is used to create a changeset that is then
executed.

When scaling down/in (i.e. reducing the number of nodes) we rely
solely on the the resulting change to the ASG. This means that
the node(s) that are to be terminated aren't drained and so pods
running on the terminating nodes may cause errors. In the future
we may consider picking the EC2 instances to be terminated and then
drain the nodes and then create a termination policy to ensure those
nodes are killed.

Issue #116

Signed-off-by: Richard Case <richard.case@outlook.com>
richardcase added a commit that referenced this issue Oct 16, 2018
@richardcase
Added nodegroup scaling
5e770fa 
Initial version of nodegroup scaling has been added. This scales
by modifying the CloudFormation template for the nodegroup. The
modified template is used to create a changeset that is then
executed.

When scaling down/in (i.e. reducing the number of nodes) we rely
solely on the the resulting change to the ASG. This means that
the node(s) that are to be terminated aren't drained and so pods
running on the terminating nodes may cause errors. In the future
we may consider picking the EC2 instances to be terminated and then
drain the nodes and then create a termination policy to ensure those
nodes are killed.

Issue #116

Signed-off-by: Richard Case <richard.case@outlook.com>
richardcase added a commit that referenced this issue Oct 16, 2018
@richardcase
Added nodegroup scaling
8f00c80 
Initial version of nodegroup scaling has been added. This scales
by modifying the CloudFormation template for the nodegroup. The
modified template is used to create a changeset that is then
executed.

When scaling down/in (i.e. reducing the number of nodes) we rely
solely on the the resulting change to the ASG. This means that
the node(s) that are to be terminated aren't drained and so pods
running on the terminating nodes may cause errors. In the future
we may consider picking the EC2 instances to be terminated and then
drain the nodes and then create a termination policy to ensure those
nodes are killed.

Issue #116

Signed-off-by: Richard Case <richard.case@outlook.com>
@errordeveloper
Copy link
Contributor

Closed via #254.

martina-if added a commit to martina-if/eksctl that referenced this issue Jan 31, 2020
@martina-if
Merge pull request eksctl-io#116 from weaveworks/test2
063e5fd 
add feature 2
torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
Merge pull request eksctl-io#116 from kubernetes-sigs/leakingtapan-pa…
9739153 
…tch-1

Update issue templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Milestone
0.1.x – improvements
Development

No branches or pull requests
3 participants
@richardcase @errordeveloper @stevesloka