Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubicorn Logger to kris-nova/logger #325

Closed
christopherhein opened this issue Nov 27, 2018 · 3 comments
Closed

Update Kubicorn Logger to kris-nova/logger #325

christopherhein opened this issue Nov 27, 2018 · 3 comments
Labels
kind/feature New feature or request

Comments

@christopherhein
Copy link
Contributor

Before creating a feature request, please search existing feature requests to see if you find a similar one. If there is a similar feature request please up-vote it and/or add your comments to it instead

Why do you want this feature?
@kris-nova has broken the logger out to make it easier to consume, this will also allow us to turn off the timestamps making the logger feel more natural as a CLI logger

What feature/behavior/change do you want?
Update kubicorn/logger references to kris-nova/logger

@christopherhein christopherhein added the kind/feature New feature or request label Nov 28, 2018
@luxas
Copy link

luxas commented Nov 28, 2018

👍 to this. However, FYI now that we have https://github.com/kubernetes/klog, we hope to make it usable for reuse for the whole k8s community. Just mentioning in case you hadn't seen it.

@krisnova
Copy link

Klog looks nice but I love the simplicity of this one as it doesn’t require a lot of dependencies. Also I feel like changing loggers should be a different issue - we already have this one and if we want to change can we start a separate thread for that?

No bias here 😁

@luxas
Copy link

luxas commented Nov 29, 2018

Oh yeah, I just happened to see this, and it was more as an FYI instead of action item, I don't feel strongly either way here 😄

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
Remove the deprecated connection-timeout flag for liveness probe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants