Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file options to enable EKS control plane logging to CloudWatch #704

Closed
whereisaaron opened this issue Apr 5, 2019 · 8 comments · Fixed by #847
Closed

Add config file options to enable EKS control plane logging to CloudWatch #704

whereisaaron opened this issue Apr 5, 2019 · 8 comments · Fixed by #847
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@whereisaaron
Copy link

whereisaaron commented Apr 5, 2019

Why do you want this feature?
We want to see the EKS control plane logs for monitoring, troubleshooting, and security audit.

What feature/behavior/change do you want?
The ability to enable/disable in the config file, each of the five control plane log types available in EKS:

  • api
  • audit
  • authenticator
  • controllerManager
  • scheduler

Documentation on EKS control plane logging API and CLI commands:
https://docs.aws.amazon.com/eks/latest/userguide/control-plane-logs.html

aws eks --region us-west-2 update-cluster-config --name prod \ --logging '{"clusterLogging":[{"types":["api","audit","authenticator","controllerManager","scheduler"],"enabled":true}]}'

Ref: aws/containers-roadmap#26

@errordeveloper
Copy link
Contributor

errordeveloper commented Apr 5, 2019

Thanks for opening this, Aaron! I'd like to do this soon, but will need to update goformation first, and we need to think about what we should enable by default.

@StevenACoffman
Copy link
Contributor

Ref: awslabs/goformation#198

@JasonSwindle
Copy link

Any progress on this? :)

@StevenACoffman
Copy link
Contributor

ref aws/containers-roadmap#242
Nope.

As soon as this is in CloudFormation (and the new resource specification is published, we can get it included in goformation.

You can run go generate in your goformation repo directory to update goformation to the latest resource specification (EKS logging isn't there as of right now) - or wait for our CI job to automatically update goformation and release a new version.

@errordeveloper
Copy link
Contributor

We are going to enable this by calling EKS API directly. Hopefully in the next release.

@errordeveloper errordeveloper self-assigned this Jun 5, 2019
@whereisaaron
Copy link
Author

Wise move @errordeveloper! Hoping for CloudFormation to catch up with API changes is a mug's game 😢. Like I'm the mug still holding out hope for EIP tags, we all gotta dream 🤣

@errordeveloper
Copy link
Contributor

@whereisaaron see #778 =)

@cdenneen
Copy link

cdenneen commented Jun 5, 2019

@whereisaaron haha I’ve raised this to my AWS account team

@errordeveloper errordeveloper added this to the 0.1.35 milestone Jun 5, 2019
@errordeveloper errordeveloper modified the milestones: 0.1.35, 0.1.36, 0.1.37 Jun 6, 2019
@errordeveloper errordeveloper modified the milestones: 0.1.38, 0.1.39 Jun 20, 2019
@errordeveloper errordeveloper modified the milestones: 0.2.0, 0.3.0 Jul 3, 2019
@cPu1 cPu1 closed this as completed in #847 Aug 2, 2019
torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
Add support for node existing service accounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants