Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added --cache as authorizer option in kubeconf #1412

Closed
wants to merge 1 commit into from

Conversation

gekart
Copy link

@gekart gekart commented Oct 7, 2019

Description

I think the credential cache option should be added to the aws-iam-authorizer call as a default, since awscli also uses caching by default. kubernetes-sigs/aws-iam-authenticator#193

This is how the resulting config would look after the PR:

       users:
        - name: kubelet@ferocious-mushroom-1532594698.us-west-2.eksctl.io
          user:
            exec:
              apiVersion: client.authentication.k8s.io/v1alpha1
              args:
              - token
              - -i
              - ferocious-mushroom-1532594698
              - --cache
              command: heptio-authenticator-aws
              env: null

Comments requested: Should I use this as the default or make it configurable? Then I'll complete the PR.

BTW, why doesn't everyone use roles & MFA for doing anything on AWS? Or am I missing something?

@gekart
Copy link
Author

gekart commented Oct 12, 2019

Closed due to lack of comment.

@gekart gekart closed this Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant