Stack tags #186
Merged
Stack tags #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
suggested changes
Sep 6, 2018
cmd/eksctl/create.go
Outdated
| @@ -67,7 +67,8 @@ func createClusterCmd() *cobra.Command { | |||
| fs.StringVarP(&cfg.ClusterName, "name", "n", "", fmt.Sprintf("EKS cluster name (generated if unspecified, e.g. %q)", exampleClusterName)) | |||
|
|
|||
| fs.StringVarP(&cfg.Region, "region", "r", DEFAULT_EKS_REGION, "AWS region") | |||
| fs.StringVarP(&cfg.Profile, "profile", "p", "", "AWS creditials profile to use (overrides the AWS_PROFILE environment variable)") | |||
| fs.StringVarP(&cfg.Profile, "profile", "p", "", "AWS credentials profile to use (overrides the AWS_PROFILE environment variable)") | |||
| fs.StringToStringVarP(&cfg.Tags, "tags", "", map[string]string{}, "Custom tags") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
pkg/cfn/manager/api.go
Outdated
| for key, value := range spec.Tags { | ||
| tags = append(tags, newTag(key, value)) | ||
| } | ||
| fmt.Println("TAGS", tags) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
README.md
Outdated
| @@ -127,6 +127,12 @@ To use a pre-existing EC2 key pair in `us-east-1` region, you can specify key pa | |||
| eksctl create cluster --ssh-public-key=my_kubernetes_key --region=us-east-1 | |||
| ``` | |||
|
|
|||
| To add custom tags to each stack, you can specify tags: | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@jmcarp thanks a lot for the PR! |
|
hey @jmcarp, do you think you could rebase and address @richardcase's comments sometime soon? |
|
Sorry, didn't see the comments! Updated. |
richardcase
approved these changes
Sep 12, 2018
errordeveloper
approved these changes
Sep 12, 2018
|
@jmcarp thanks a lot! |
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Update run-e2e-test script to setup cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly resolves #150, except for #25.