-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict parser for config file (with kube 1.16+ dependencies) #1874
Conversation
2a5d3dd
to
47e5eab
Compare
aafe02f
to
add6b08
Compare
add6b08
to
fb0267e
Compare
fb0267e
to
bba6662
Compare
f0aba05
to
9468fad
Compare
9468fad
to
af75e5d
Compare
c7ba8c0
to
202d9f5
Compare
@martina-if @cPu1 whenever you have time, your input is highly appreciated 🎉 |
Hi @sayboras , I think we should not make the config file parser strict yet until we decide how we want to deal with multiple schema versions. If we make the parser strict that will make forward compatibility impossible so I think it's better to close this for now. |
@martina-if I have very limited idea on supporting multiple API versions. Normally, I just go ahead with different loaders :) Sure, let me close this one for now, I can re-open it once I have better understanding 💯 |
Description
Fixes #1861 and #1602
https://github.com/kubernetes/apimachinery already supports strict parser as per kubernetes/apimachinery@162a2da. However, this is only available in kube 1.16, so I need to update all libraries to latest 1.16 version
Updated on 01-May-2020
As per today, EKS is supporting kube 1.16, so I think it's fair to upgrade the dependencies to 1.16.x, and eventually we can fix underlying validation issues.
Successfully create cluster
Wrong case in configuration file
Checklist
README.md
, or thesite/content
directory)area/nodegroup
), target version (e.g.version/0.12.0
) and kind (e.g.kind/improvement
)