Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto resolver bug #219

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Auto resolver bug #219

merged 2 commits into from
Sep 19, 2018

Conversation

richardcase
Copy link
Contributor

Description

The 'auto' ami resolver has been updated so that it picks the newst image. Previously it would pick the first image which might have been the oldest.

The 'static' resolver has been updated with the latest (v24) images to use for the nodes.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README)
  • Added yourself to the humans.txt file

The auto AMI resolver will now pick the latest AMI version to use.
Previously it just picked the first image and used that.

Issue #218
The static resolver has been updated to use the latest (v24)
images for the EKS nodes. This applies to both normal and
GPU instance types.
Copy link
Contributor

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @richardcase

@richardcase richardcase merged commit 0281776 into master Sep 19, 2018
@errordeveloper errordeveloper deleted the auto-resolver-bug branch October 16, 2018 22:38
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
…t-tests

Add unit tests for ControllerPublish and ControllerUnpublish requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants