Generation of static AMI list #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @richardcase GitHub says that your branch is out of date with master, can you do rebase. |
The list of AMIs to use for the static resolver is now generated via go:generate. The list is queried from AWS and output to a code file. A separate makefile target called 'generate-ami' has been added that runs go generate. The reason for a separate target is the fact that AWS credentials are required for the code generation and this would break the current workflow for the 'generate' target. Another makefile target called 'ami-check' has been added. The intended purpose of this by an automated scheduled process that will run to check if new images are available. Issue #49
The dockerfile for eksctl has been update to explicitly call the 'build' goal. And the default goal for the makefile has been set to the new 'help' goal which print help/usage information.
richardcase
force-pushed
the
static-ami-generator
branch
from
0e68dc6 to
23aaab4
Compare
|
Ah, rebased now. Thanks @stefanprodan |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The list of AMIs to use for the static resolver is now generated
via go:generate. The list is queried from AWS and output to a code
file.
A separate makefile target called 'generate-ami' has been added that
runs go generate. The reason for a separate target is the fact that
AWS credentials are required for the code generation and this would
break the current workflow for the 'generate' target.
Another makefile target called 'ami-check' has been added. The
intended purpose of this by an automated scheduled process that
will run to check if new images are available.
Issue #49
Checklist
make build)make test)humans.txtfile