Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed minor typos throughout project #223

Merged
merged 1 commit into from
Sep 21, 2018
Merged

fixed minor typos throughout project #223

merged 1 commit into from
Sep 21, 2018

Conversation

kschumy
Copy link

@kschumy kschumy commented Sep 21, 2018

Description

Fixed minor typos in multiple files

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README)
  • Added yourself to the humans.txt file

richardcase
richardcase suggested changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @kschumy.

This looks good to me, could you rebase with master?

@kschumy
Copy link
Author

kschumy commented Sep 21, 2018

Done!

richardcase
richardcase approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @kschumy! This looks good to me.

@kschumy kschumy merged commit a837045 into eksctl-io:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kschumy @richardcase