Configure node volume size #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarp
force-pushed
the
issue-214-volume-size
branch
from
3088098 to
af7bb0e
Compare
jmcarp
force-pushed
the
issue-214-volume-size
branch
from
af7bb0e to
32c81b9
Compare
|
Actually, noticed that encryption doesn't work here, since the ebs snapshots associated with the base AMIs aren't encrypted. Rolling back to just configuring volume size. |
| NodeAMI string | ||
| NodeType string | ||
| Nodes int | ||
| NodeVolumeSize int |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
cmd/eksctl/create.go
Outdated
| @@ -66,6 +66,7 @@ func createClusterCmd() *cobra.Command { | |||
|
|
|||
| fs.StringVarP(&cfg.Region, "region", "r", api.DEFAULT_EKS_REGION, "AWS region") | |||
| fs.StringVarP(&cfg.Profile, "profile", "p", "", "AWS credentials profile to use (overrides the AWS_PROFILE environment variable)") | |||
| fs.IntVarP(&cfg.NodeVolumeSize, "node-volume-size", "", 0, "Node volume size (in GB)") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
README.md
Outdated
| To configure node volume size, use the `--node-volume-size` flag. | ||
|
|
||
| ``` | ||
| eksctl create cluster --node-volume-size 50 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Thanks, updated. |
|
@errordeveloper: anything else I should update here? |
richardcase
reviewed
Oct 4, 2018
errordeveloper
approved these changes
Oct 5, 2018
|
@jmcarp thanks, this is great! |
errordeveloper
changed the title
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
fix a bug when capacity range is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #214]
We should probably look up the root device name from the AMI instead of hard-coding
/dev/xvda. Happy to add that here if that makes sense.Description
Please explain the changes you made here.
Checklist
make build)make test)humans.txtfile