Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Allow 443 between control plane and nodes #234

Merged
merged 2 commits into from
Oct 5, 2018
Merged

WIP: Allow 443 between control plane and nodes #234

merged 2 commits into from
Oct 5, 2018

Conversation

richardcase
Copy link
Contributor

@richardcase richardcase commented Oct 1, 2018 •
edited
Loading

Description

To help with metrics collection from the nodes
port 443 has been opened between the control plane
and node group.

Issue #233

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README)
  • Added yourself to the humans.txt file

@richardcase
Allow 443 between control plane and nodes
70832ea 
To help witj metrics collection from the nodes
port 443 has been opened between the control plane
and node group.

Issue #233
@richardcase
Fixed tests
da49ed0
@errordeveloper errordeveloper merged commit d895df4 into master Oct 5, 2018
@errordeveloper errordeveloper deleted the metrics-server branch October 5, 2018 12:22
@errordeveloper errordeveloper mentioned this pull request Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardcase @errordeveloper