Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CP to nodes egress rule for port 443, imporve descriptions #239

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Add CP to nodes egress rule for port 443, imporve descriptions #239

merged 1 commit into from
Oct 5, 2018

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Oct 5, 2018 •
edited
Loading

Description

Fixes #233.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README)
  • Added yourself to the humans.txt file

richardcase
richardcase approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes that makes sense. This looks good to me.

@errordeveloper errordeveloper merged commit 7e3e686 into master Oct 5, 2018
@errordeveloper errordeveloper deleted the fix-233 branch October 5, 2018 14:44
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
Merge pull request eksctl-io#239 from leakingtapan/readme
a33d6c7 
Update driver README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errordeveloper @richardcase