Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait flag for delete cluster command #262

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Add wait flag for delete cluster command #262

merged 1 commit into from
Oct 16, 2018

Conversation

Lazyshot
Copy link

Adding ability for a user to have the delete cluster command
wait until all resources are removed before exiting.

Issue #213

Note: Reopened due to issue with NodeGroup stacks must be fully deleted before the cluster stack deletion can be requested.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README)
  • Added yourself to the humans.txt file

Adding ability for a user to have the delete cluster command
wait until all resources are removed before exiting.

Issue #213
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

It makes sense enforcing the wait for the node group to delete.

@errordeveloper errordeveloper merged commit 3ebac17 into eksctl-io:master Oct 16, 2018
@errordeveloper
Copy link
Contributor

It makes sense enforcing the wait for the node group to delete.

This is required because nodegroup stack imports values from cluster stack, which implies cluster stack cannot be deleted while there exists a stack that imports any of the exported values.

@richardcase richardcase mentioned this pull request Oct 16, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants