Fix & cleanup integration test #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use single Describe block to avoid ordering issues - rename variables and functions to match overall style
errordeveloper
force-pushed
the
improve-integration-test
branch
2 times, most recently
from
ea2bdb5 to
263661e
Compare
golangcibot
reviewed
Oct 16, 2018
errordeveloper
force-pushed
the
improve-integration-test
branch
3 times, most recently
from
5141295 to
a0c7e2e
Compare
- cosmetic style changes and refactoring - get rid of nested directory - remove dead code - unexport matcher struct - use canonical tag key - update suite name
errordeveloper
force-pushed
the
improve-integration-test
branch
from
a0c7e2e to
36cde0a
Compare
errordeveloper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix & cleanup integration test
Checklist
make build)make test)humans.txtfile